Skip to content

chore: switch BootstrapSynchronisation feature gate to opt-out - #3590

Merged
scylla-operator-bot[bot] merged 3 commits into
scylladb:masterfrom
rzetelskik:opt-out-bootstrap-sync
Aug 14, 2026
Merged

chore: switch BootstrapSynchronisation feature gate to opt-out#3590
scylla-operator-bot[bot] merged 3 commits into
scylladb:masterfrom
rzetelskik:opt-out-bootstrap-sync

Conversation

@rzetelskik

@rzetelskik rzetelskik commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description of your changes: This PR switches the BootstrapSynchronisation feature gate to opt-out.

Which issue is resolved by this Pull Request:
Resolves https://scylladb.atlassian.net/browse/OPERATOR-310

/cc

@scylla-operator-bot

scylla-operator-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves https://scylladb.atlassian.net/browse/OPERATOR-310

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2026
@github-actions github-actions Bot added the P3 label Aug 13, 2026
@scylla-operator-bot scylla-operator-bot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2026
@rzetelskik

rzetelskik commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

/auto-cc
/hold for parallel bootstrap PRs to land not to retrigger CI

@scylla-operator-bot scylla-operator-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2026
@scylla-operator-bot
scylla-operator-bot Bot requested a review from czeslavo August 13, 2026 13:37
@rzetelskik rzetelskik changed the title [WIP] chore: switch BootstrapSynchronisation feature gate to opt-out chore: switch BootstrapSynchronisation feature gate to opt-out Aug 13, 2026
@scylla-operator-bot scylla-operator-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2026
czeslavo
czeslavo approved these changes Aug 13, 2026
View reviewed changes

@czeslavo czeslavo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026
@scylla-operator-bot

scylla-operator-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czeslavo, rzetelskik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [czeslavo,rzetelskik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mflendrich

mflendrich commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Can we discuss this before merging? added a meeting for tomorrow with an alternative approach

/hold

@rzetelskik

rzetelskik commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

/test images
/retest

@mflendrich

mflendrich commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Decision reached with @czeslavo @rzetelskik:

  • enable the bootstrap sync feature gate by default (because the cost of generating & propagating the node status reports is already incurred regardless of the setting of the gate, which only enables/disables the barrier)
  • make a feature request to Core to make the "new node joining" operation idempotent/retryable
  • once the Core feature is implemented: retire the bootstrap sync mechanism

/hold cancel

@scylla-operator-bot scylla-operator-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2026
@scylla-operator-bot
scylla-operator-bot Bot merged commit ad33f77 into scylladb:master Aug 14, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czeslavo czeslavo czeslavo approved these changes

Assignees

@czeslavo czeslavo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. P3 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzetelskik @mflendrich @czeslavo